[webkit-reviews] review denied: [Bug 33714] [Qt] QWebSettings attribute for toggle SNav (Spatial Navigation) on/off : [Attachment 46698] patch 0.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 16 00:50:11 PST 2010


Simon Hausmann <hausmann at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 33714: [Qt] QWebSettings attribute for toggle SNav (Spatial Navigation)
on/off
https://bugs.webkit.org/show_bug.cgi?id=33714

Attachment 46698: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=46698&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Antonio, I think your patch looks fine, but I would prefer a slightly more
elaborate explanation in the docs on what the _effect_ of enabling this feature
is, i.e. that it affects the keyboard navigation.


More information about the webkit-reviews mailing list