[webkit-reviews] review requested: [Bug 33757] Reduce duplication in run-webkit-httpd and run-webkit-tests : [Attachment 46737] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 22:10:16 PST 2010


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 33757: Reduce duplication in run-webkit-httpd and run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=33757

Attachment 46737: Patch
https://bugs.webkit.org/attachment.cgi?id=46737&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Currently both scripts have code to figure out the name of the apache2
executable and which configuration file to use for the server. I'm currently
in the process of making run-iexploder-tests work for everyone else and
would have to copy the code again.
Instead of copying it to the iexploder-tests script I'm copying it to
webkitdirs.pm and make both existing scripts use the new method to
figure out httpdPath and httpdConfiguration.


More information about the webkit-reviews mailing list