[webkit-reviews] review denied: [Bug 33731] Remove uses of PtrAndFlags : [Attachment 46700] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 12:58:57 PST 2010


Oliver Hunt <oliver at apple.com> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 33731: Remove uses of PtrAndFlags
https://bugs.webkit.org/show_bug.cgi?id=33731

Attachment 46700: The patch
https://bugs.webkit.org/attachment.cgi?id=46700&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r-, i think 
cachedPrototypeStructure = (Structure*)1
 should be

static const Structure* seenFlag = (Structure*)1;

cachedPrototypeStructure = seenFlag

(with a better name for seenFlag)


More information about the webkit-reviews mailing list