[webkit-reviews] review denied: [Bug 33310] editing/pasteboard/4641033.html timed out on Tiger Bot : [Attachment 46697] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 15 12:28:47 PST 2010
Alexey Proskuryakov <ap at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 33310: editing/pasteboard/4641033.html timed out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33310
Attachment 46697: Patch
https://bugs.webkit.org/attachment.cgi?id=46697&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm not sure if setTimeout is unnecessary - the original bug was about DOM
traversal and presence or renderers, and the DOM is different when still
parsing. If this isn't going to fix the problem, better not make arbitrary
changes.
One possible reason for the test to time out would be an exception being
raised. Maybe you could add a try/catch block instead, and log the exception?
More information about the webkit-reviews
mailing list