[webkit-reviews] review granted: [Bug 33476] Change VCSUtils::parseDiffHeader() to skip over unrecognized lines : [Attachment 46550] Proposed patch 3

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 33476: Change VCSUtils::parseDiffHeader() to skip over unrecognized lines
https://bugs.webkit.org/show_bug.cgi?id=33476

Attachment 46550: Proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=46550&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> -plan(tests => @diffTests * 8); # Eight assertions per call to doDiffTest().
> +plan(tests => @diffTests * 6); # Multiply by number of assertions per call
to doDiffTest().

It would be really cool if there was a way to "count" the number of assertions
in code, but it's not necessary for this patch.  (I'm not sure if it's
possible, either, unless you make the assertions an array of strings that are
eval-ed.)

r=me

Let's try with the commit queue per Eric's Comment #11.