[webkit-reviews] review denied: [Bug 33689] WebSocket: Missing Request-URI, when no tralling slash in host : [Attachment 46648] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 15 08:47:22 PST 2010
Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 33689: WebSocket: Missing Request-URI, when no tralling slash in host
https://bugs.webkit.org/show_bug.cgi?id=33689
Attachment 46648: Patch
https://bugs.webkit.org/attachment.cgi?id=46648&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Code changes look good, but I think I'll ask to rework the test. It has
absolutely no reason to be script-tests-based - it doesn't have even a single
shouldBe anywhere! A bigger issue is that test output doesn't really mention
pass/fail criteria, and that it relies on assertions that may be gone at the
same time the bug is reintroduced.
A more reliable way to test this would be for the server to report invalid
requests in some manner (possibly by setting a state that can be retrieved
later, or maybe by intercepting these and forwarding to a specific handler
whose response we could check).
More information about the webkit-reviews
mailing list