[webkit-reviews] review denied: [Bug 33710] WebCore/bridge/jni/jsc should be renamed WebCore/bridge/jni/js : [Attachment 46664] Patch 1 for Bug 33710

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 03:23:41 PST 2010


Mark Rowe (bdash) <mrowe at apple.com> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 33710: WebCore/bridge/jni/jsc should be renamed WebCore/bridge/jni/js
https://bugs.webkit.org/show_bug.cgi?id=33710

Attachment 46664: Patch 1 for Bug 33710
https://bugs.webkit.org/attachment.cgi?id=46664&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
JNI is an acronym and therefore should be expressed in all caps rather than in
title case.

Is there some reason that you’re renaming only two of the 13 files that are
named in this manner?  It would be more logical to me if you did the directory
rename in one step, and then renamed all of the misnamed files at once in a
follow-up change.


More information about the webkit-reviews mailing list