[webkit-reviews] review requested: [Bug 33418] [Qt] Custom select popups. : [Attachment 46653] Custom popups and popup factories.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 01:30:10 PST 2010


Luiz Agostini <luiz.agostini at openbossa.org> has asked  for review:
Bug 33418: [Qt] Custom select popups.
https://bugs.webkit.org/show_bug.cgi?id=33418

Attachment 46653: Custom popups and popup factories.
https://bugs.webkit.org/attachment.cgi?id=46653&action=review

------- Additional Comments from Luiz Agostini <luiz.agostini at openbossa.org>

main changes in this patch:
   * make the API public.
   * change the name from QWebPopup to QWebSelectPopupDelegate.
   * remove the abstract method setParent and create a new non virtual method
QWidget* parentWidget() in QWebSelectPopupDelegate. It can be useful for those
who use QWidgets in their popup customizations but can be ignored by those that
do not.
   * remove the usage example from the patch.


More information about the webkit-reviews mailing list