[webkit-reviews] review granted: [Bug 19650] -webkit-gradient slows down scrolling when page has horizontal scrollbar : [Attachment 46638] Use 1-by-n tiles for horizontal and vertical linear gradients

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 19650: -webkit-gradient slows down scrolling when page has horizontal
scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650

Attachment 46638: Use 1-by-n tiles for horizontal and vertical linear gradients
https://bugs.webkit.org/attachment.cgi?id=46638&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/platform/graphics/Generator.h
> ===================================================================

>      virtual void fill(GraphicsContext*, const FloatRect&) = 0;
> +    virtual void adjustParametersForTiledDrawing(IntSize& /* size */,
FloatRect& /* srcRect */, TransformationMatrix& /* patternTransform */,
FloatPoint& /* phase */) { 

Maybe remove patternTransform and phase from this method if you think they will
never be used. They can easily be added if we find a use.

r=me