[webkit-reviews] review granted: [Bug 33691] Drag and Drop source/destination code needs cleanup : [Attachment 46615] Patch that works on Qt and Chromium

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 33691: Drag and Drop source/destination code needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=33691

Attachment 46615: Patch that works on Qt and Chromium
https://bugs.webkit.org/attachment.cgi?id=46615&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  void Clipboard::setSourceOperation(DragOperation op)
>  {
> +    ASSERT(op != DragOperationPrivate);
>      m_effectAllowed = IEOpFromDragOp(op);
>  }
>  
>  void Clipboard::setDestinationOperation(DragOperation op)
>  {
> +    ASSERT(op == DragOperationCopy || op == DragOperationNone || op ==
DragOperationLink || op == DragOperationMove);
>      m_dropEffect = IEOpFromDragOp(op);
>  }

ASSERT_ARG would be better for these.

This looks fine to land. But I don't want to forget to find out if removing our
old IE-compat code is going to bite us in the end. Maybe we should get a bug
filed saying that we need to do more testing? (E.g., it would be useful to find
out if IE even still has this behavior.)