[webkit-reviews] review requested: [Bug 28751] Misc. small image system cleanups : [Attachment 46606] Condense downsampling logic

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 14:37:15 PST 2010


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 28751: Misc. small image system cleanups
https://bugs.webkit.org/show_bug.cgi?id=28751

Attachment 46606: Condense downsampling logic
https://bugs.webkit.org/attachment.cgi?id=46606&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This greatly reduces the amount of code in the decoders that support image
downsampling.  It does this by making the downsampling functions available for
all builds, and having them act "as you'd expect" (e.g. scaledSize() returns
the same as size() when the image has not been scaled).  This allowed me to
condense a lot of logic.

This also contains the fixes on bug 33624 (which I discovered while writing
this patch).

There should be no functional change in this patch.


More information about the webkit-reviews mailing list