[webkit-reviews] review denied: [Bug 33395] Commit bot should land patches in order of last modification date : [Attachment 46268] Patch 1 for Bug 33395

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 13:56:12 PST 2010


Eric Seidel <eric at webkit.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 33395: Commit bot should land patches in order of last modification date
https://bugs.webkit.org/show_bug.cgi?id=33395

Attachment 46268: Patch 1 for Bug 33395
https://bugs.webkit.org/attachment.cgi?id=46268&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this is a fantastic idea.  However, this will land them in bug
modification order, not patch modification order.  It that what you really
intended?  I think  the proper fix involves parsing the flag set date out of
the attachment and then sorting by that in CommitQueue.next_work_item

I'm about to land a patch which moves CommitQueue.next_work_item away from
using fetch_patches_in_commit_queue because of bug 33638.  But we can still
easily sort the patches after that change.

r- because this patch doesn't actually do what it claims to do.


More information about the webkit-reviews mailing list