[webkit-reviews] review granted: [Bug 33533] window.onload never fires if page contains an <iframe> with a bad scheme or whose load is cancelled by returning null from resource load delegate's willSendRequest : [Attachment 46590] Treat all synchronous loads equally in FrameLoader::loadSubframe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 11:18:07 PST 2010


Brady Eidson <beidson at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 33533: window.onload never fires if page contains an <iframe> with a bad
scheme or whose load is cancelled by returning null from resource load
delegate's willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=33533

Attachment 46590: Treat all synchronous loads equally in
FrameLoader::loadSubframe
https://bugs.webkit.org/attachment.cgi?id=46590&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Since the new layouttestcontroller voodoo is only on windows and mac for now,
you should add the tests that rely on it to the skipped list for the other
platforms (unless I'm missing something as to why they wouldn't fail)

r+ with that change.


More information about the webkit-reviews mailing list