[webkit-reviews] review denied: [Bug 19268] Profiles panel should make recording the first profile more obvious : [Attachment 46581] generalized version
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 14 10:42:18 PST 2010
Timothy Hatcher <timothy at hatcher.name> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 19268: Profiles panel should make recording the first profile more obvious
https://bugs.webkit.org/show_bug.cgi?id=19268
Attachment 46581: generalized version
https://bugs.webkit.org/attachment.cgi?id=46581&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + function messageButtonClicked()
> + {
> + profileType.buttonClicked.call(profileType);
> + }
This does not need to use .call(). You can also just use
profileType.buttonClicked.bind(profileType) and pass it to addEventListener.
Fix that and I'll r+.
More information about the webkit-reviews
mailing list