[webkit-reviews] review requested: [Bug 18662] Extend keyboard navigation to allow directional navigation : [Attachment 46576] Add directional navigation to WebCore (v8)

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 18662: Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662

Attachment 46576: Add directional navigation to WebCore (v8)
https://bugs.webkit.org/attachment.cgi?id=46576&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Patch v8:

1) Improves the algorithm inicially proposed by Marco Barisione:
* Now it is based on a super-precedence logic, whereas rects whose middle
  falls between the top or bottom of the current rect are preferible to
  move focus to. It falls back to the common eucledian distance.
2) Adds LayoutLayout for the following edge cases:
* table traversal.
* iframe traversal (no scrollable content).
* unit-overflow during distance calculation.
* scroll-in-direction.
* super precedence in vertical direction.


TODO in followup bugs:
* Add port specific hooks to each DRTs to enable/disable Spatial Navigation.
* Form navigation and SNav interaction.
* Better support Iframes with scrollable content.
* Make navigation keys customizable. It currently works with arrows keys only
  (up, down, right and left).
* Make it support modifiers (Alt, Ctrl and Shift).