[webkit-reviews] review requested: [Bug 33153] [multi-patch]Running multiple instances of run-webkit-tests is not possible on the same machine : [Attachment 46575] Extract Apache handling to httpd.pm module

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 09:30:14 PST 2010


Andras Becsi <abecsi at inf.u-szeged.hu> has asked  for review:
Bug 33153: [multi-patch]Running multiple instances of run-webkit-tests is not
possible on the same machine
https://bugs.webkit.org/show_bug.cgi?id=33153

Attachment 46575: Extract Apache handling to httpd.pm module
https://bugs.webkit.org/attachment.cgi?id=46575&action=review

------- Additional Comments from Andras Becsi <abecsi at inf.u-szeged.hu>
Extract Apache handling to httpd.pm module and use the provided functionality
in scripts where Apache is needed.
The module httpd.pm stores the PID of the current Apache daemon in a variable
and cleans up the PID directory after Apache properly shut down.
Catching INT and TERM signals allows the scrips to shut down Apache properly
even if the testing was interrupted.

The next step will be enabling per-instance temp dirs for run-webkit-tests, so
there will be no conflict with leftower files in /tmp and the undeleted symlink
/tmp/LayoutTests, which is needed for some tests. This however requires changes
in some 20 tests which hardcode /tmp in their javascript code to get the tmp
dir path from LayoutTestController.
After enabling the setting of a custom path for local storage and icon database
(located now in .local), the last step will be the --wait-for-httpd switch for
run-webkit-tests which uses a locking mechanism to ensure that only one tester
at a time runs the http tests.


More information about the webkit-reviews mailing list