[webkit-reviews] review denied: [Bug 19268] Profiles panel should make recording the first profile more obvious : [Attachment 46573] Now using '--binary' for localizedStrings

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 19268: Profiles panel should make recording the first profile more obvious
https://bugs.webkit.org/show_bug.cgi?id=19268

Attachment 46573: Now using '--binary' for localizedStrings
https://bugs.webkit.org/attachment.cgi?id=46573&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +++ b/WebCore/inspector/front-end/ProfilesWelcomeView.js

I think this should not be specific to Profiles panel, and should be generic
for use by other Panels.


> +    registerProfileType: function(profileType)

This can be generalized to take just an HTML message, then it isn't Profiles
specific.


> +	   } else {
> +	       messageElement.innerHTML = message;
> +	   }

No braces here.


> +.panel-enabler-view.profiles.welcome {
> +.panel-enabler-view.profiles.welcome img {
> +.panel-enabler-view.profiles.welcome .instructions {
> +.panel-enabler-view.profiles.welcome .profile-type-message {
> +.panel-enabler-view.welcome button {

These selectors don't need .profiles in them. They can be generic to all
welcome views.

I think this is fine as, but I would like to see it be more generic.