[webkit-reviews] review denied: [Bug 33614] [Qt] Missing fileSystemPath() method in Qt KURL implementation : [Attachment 46506] Proposed patch v0.3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 14 03:01:10 PST 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Diego Gonzalez
<diego.gonzalez at openbossa.org>'s request for review:
Bug 33614: [Qt] Missing fileSystemPath() method in Qt KURL implementation
https://bugs.webkit.org/show_bug.cgi?id=33614
Attachment 46506: Proposed patch v0.3
https://bugs.webkit.org/attachment.cgi?id=46506&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
>
> String KURL::fileSystemPath() const
> {
> - notImplemented();
> + if (m_string.isEmpty())
> + return String();
> +
> +#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
> + QUrl url = QUrl::fromUserInput(m_string);
Why use this? This might change an invalid URL into a valid one. This doesn't
seem right and at least needs a comment
> +#else
> + QUrl url = QUrl(m_string);
> +#endif
> + if (url.isValid())
> + return String(url.path());
> +
> return String();
> }
>
More information about the webkit-reviews
mailing list