[webkit-reviews] review granted: [Bug 33620] check-webkit-style: Move error() from cpp_style.py to checker.py : [Attachment 46543] Proposed patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 01:06:37 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 33620: check-webkit-style: Move error() from cpp_style.py to checker.py
https://bugs.webkit.org/show_bug.cgi?id=33620

Attachment 46543: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=46543&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the description and fixing issues. I've found you fixed
s/self.handle_error/self._handle_error/ . Thanks for catching this issue and
sorry I didn't notice it. I think this means we want StyleCheckerTest later.
Could you work for this? Otherwise, I'll write it.


More information about the webkit-reviews mailing list