[webkit-reviews] review granted: [Bug 33617] [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController : [Attachment 46507] Proposed patch v0.2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 13 23:38:00 PST 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diego.gonzalez at openbossa.org>'s request for review:
Bug 33617: [Qt] DRT missing setUserStyleSheetLocation and
setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617
Attachment 46507: Proposed patch v0.2
https://bugs.webkit.org/attachment.cgi?id=46507&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
LGTM, r=me
> + if (enabled)
> +
m_drt->webPage()->settings()->setUserStyleSheetUrl(m_userStyleSheetLocation);
> + else
> + m_drt->webPage()->settings()->setUserStyleSheetUrl(QUrl());
Do you know what happens if I give an invalid url to setUserStyleSheetUrl? Is
that handled?
More information about the webkit-reviews
mailing list