[webkit-reviews] review canceled: [Bug 32722] Allow Reserved Words in Property Accessors : [Attachment 46153] patch so far

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has canceled Patrick Mueller
<pmuellr at yahoo.com>'s request for review:
Bug 32722: Allow Reserved Words in Property Accessors
https://bugs.webkit.org/show_bug.cgi?id=32722

Attachment 46153: patch so far
https://bugs.webkit.org/attachment.cgi?id=46153&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
I played with the grammar some more, after reading the Bison doc.  Main goal
was to split out the IdentifierOrReserved patterns into two, in hopes it would
require less work to match the common cases.  Also, keeping the semantic type
of the keywords undefined, except in the case of the new Reserved non-terminal.
 I think it was a little successful.  SunSpider runs were generally faster than
with the previous patch, but also didn't quite get as fast as the original
parser.  At this point, I think I'll do some profiling of the parser to see if
anything shows up.