[webkit-reviews] review granted: [Bug 33607] REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed is set (differs from HTML5) : [Attachment 46500] [PATCH] Simpler Fix with Adam's Comments

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 33607: REGRESSION (r49268): DHTML drag not allowed unless
event.dataTransfer.effectAllowed is set (differs from HTML5)
https://bugs.webkit.org/show_bug.cgi?id=33607

Attachment 46500: [PATCH] Simpler Fix with Adam's Comments
https://bugs.webkit.org/attachment.cgi?id=46500&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  Clipboard::Clipboard(ClipboardAccessPolicy policy, bool isForDragging) 
>      : m_policy(policy) 
> +    , m_effectAllowed("uninitialized")

At some point we should switch m_effectAllowed to be an AtomicString. Maybe
when we fix setEffectAllowed to only allow setting it to certain values?

r=me