[webkit-reviews] review granted: [Bug 33619] Move more of the selection and caret painting code from Frame to SelectionController : [Attachment 46488] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 33619: Move more of the selection and caret painting code from Frame to
SelectionController
https://bugs.webkit.org/show_bug.cgi?id=33619

Attachment 46488: Patch
https://bugs.webkit.org/attachment.cgi?id=46488&action=review

------- Additional Comments from mitz at webkit.org
> +	   "layout" is usedfor other purposes in this function.

Typo: “usedfor”

> -    bool m_needsLayout : 1;	     // true if the caret and expectedVisible
rectangles need to be calculated
> +    bool m_needsLayout; // true if the caret and expectedVisible rectangles
need to be calculated

I don’t know what expectedVisible is, in this comment that you’re moving.

r=me but this apparently breaks the Qt build:
<https://webkit-commit-queue.appspot.com/results/184631>.