[webkit-reviews] review denied: [Bug 33408] Add flag IGNORE_FIXED_BACKGROUNDS (disabled by default) to ignore fixed background images and accelerate web page scrolling on low-powered/mobile devices : [Attachment 46177] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 13 12:07:49 PST 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied  review:
Bug 33408: Add flag IGNORE_FIXED_BACKGROUNDS (disabled by default) to ignore
fixed background images and accelerate web page scrolling on low-powered/mobile
devices
https://bugs.webkit.org/show_bug.cgi?id=33408

Attachment 46177: Patch 2
https://bugs.webkit.org/attachment.cgi?id=46177&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #6)
> If this is a platform decision, why not just check in platform-specific
> results?

Since this is a platform-specific, compile-time decision, I think it would be
best to simply check in "failing" test results as expected results instead of
trying to do something fancy in run-webkit-tests.  That way, you still get test
coverage for the tests, and you'll know if the results ever change, e.g., if
someone accidentally turns the flag back on for your port!


More information about the webkit-reviews mailing list