[webkit-reviews] review canceled: [Bug 33408] Add flag IGNORE_FIXED_BACKGROUNDS (disabled by default) to ignore fixed background images and accelerate web page scrolling on low-powered/mobile devices : [Attachment 46177] Patch 2

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 33408: Add flag IGNORE_FIXED_BACKGROUNDS (disabled by default) to ignore
fixed background images and accelerate web page scrolling on low-powered/mobile
devices
https://bugs.webkit.org/show_bug.cgi?id=33408

Attachment 46177: Patch 2
https://bugs.webkit.org/attachment.cgi?id=46177&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebCore/WebCore.IgnoreFixedBackgrounds.exp
> ===================================================================
> --- WebCore/WebCore.IgnoreFixedBackgrounds.exp	(revision 0)
> +++ WebCore/WebCore.IgnoreFixedBackgrounds.exp	(revision 0)
> @@ -0,0 +1 @@
> +_WebCoreIgnoreFixedBackgrounds

I don't see this method (or variable) implemented anywhere in the patch.

If this is a platform decision, why not just check in platform-specific
results?  Why is a build setting needed at all since you're not actually
changing any code?

It seems like an awful lot of work just to add a flag that is used by
run-webkit-tests to check results for a given platform.