[webkit-reviews] review denied: [Bug 33596] DebuggerActivation::getOwnPropertyNames() should delegate to JSActivation::getOwnPropertyNames() : [Attachment 46452] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 13 09:33:14 PST 2010


Darin Adler <darin at apple.com> has denied Kent Hansen <kent.hansen at nokia.com>'s
request for review:
Bug 33596: DebuggerActivation::getOwnPropertyNames() should delegate to
JSActivation::getOwnPropertyNames()
https://bugs.webkit.org/show_bug.cgi?id=33596

Attachment 46452: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=46452&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Ideally the change log should have a comment explaining why it's impossible,
impractical, or unnecessary to create a test case for this. Normally we do not
accept bug fix patches without a test case or an explanation for why one is not
possible.

I'm torn, and I was *this close* to just saying review+, but I don't think it
will hurt to give Kent a chance to consider making a test case or explaining
why not.


More information about the webkit-reviews mailing list