[webkit-reviews] review requested: [Bug 33590] [GTK] GObject DOM bindings : [Attachment 46453] gobjectdombindings.patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 33590: [GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Attachment 46453: gobjectdombindings.patch
https://bugs.webkit.org/attachment.cgi?id=46453&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
The main patch.

As was suggested in the original bug, I have reduced the scope of the patch,
and I'm just generating bindings for a fairly small subset of the IDL files.
Some comments:

- I basically provide Node.idl and all its dependencies (a ~dozen files) with
two exceptions:
  * The ownerDocument method is excluded for the GObject bindings, since it
brings along a lot of other files (through Document.idl) and thus defeats the
purpose of a reduced initial patch. This would be the first thing to correct in
a follow-up.
  * The EventListener feature is also excluded.
- I changed the prefix for the DOM methods to "WebKitDOM", as discussed in the
old bug.
- I have removed lots of corner cases and hacks from the generator script, plus
some heavy refactoring in some places. It's still not the prettiest thing, but
I think it's more readable and it's about 300 lines shorter than the previous
shortest version.
- Overall the patch is about 40K smaller than the previous smallest patch
(which was about ~110K). I'm sure it can be made more clear/better in many
places, but I'm not sure it can be made smaller in scope than it is, so this is
pretty much it as far as complexity is concerned I'd say.

I'll attach another patch that adds a 'inner-node' property to
WebKitHitTestResult as an example and proof that the whole thing works :)