[webkit-reviews] review granted: [Bug 33587] Web Inspector: Scrolling editor to the 20Kth line is not smooth. : [Attachment 46443] [PATCH] Proposed change.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 13 04:46:27 PST 2010
Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 33587: Web Inspector: Scrolling editor to the 20Kth line is not smooth.
https://bugs.webkit.org/show_bug.cgi?id=33587
Attachment 46443: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=46443&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + // User keeps updating the job in between of our timer ticks.
Just reschedule self, don't eat CPU (he must be scrolling).
s/he must/they must/
> + // Highlight 1K lines chunk.
> + var toLine = Math.min(startLine + 500, this._requestedEndLine);
s/1K lines/500 lines/
More information about the webkit-reviews
mailing list