[webkit-reviews] review denied: [Bug 33579] Web Inspector: speed-up Timeline panel scrolling : [Attachment 46436] Patch file with changes in TimelinePanel.js and WebCore/ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 13 02:08:20 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 33579: Web Inspector: speed-up Timeline panel scrolling
https://bugs.webkit.org/show_bug.cgi?id=33579

Attachment 46436: Patch file with changes in TimelinePanel.js and
WebCore/ChangeLog
https://bugs.webkit.org/attachment.cgi?id=46436&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good. Few suggestions on the naming before it lands:

> +    this._updateBoundaries = false;

this._updateBoundaries -> this._boundariesAreValid (and inverse the meaning)

>  
>      _scheduleRefresh: function(immediate)
>      {

immediate -> preserveBoundaries

> +    _refreshRecords: function(updateBoundaries)


More information about the webkit-reviews mailing list