[webkit-reviews] review denied: [Bug 33554] run-webkit-tests fails on Ruby 1.9 : [Attachment 46402] Bugfix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 23:52:56 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has denied Janusz Lewandowski
<lew21 at xtreeme.org>'s request for review:
Bug 33554: run-webkit-tests fails on Ruby 1.9
https://bugs.webkit.org/show_bug.cgi?id=33554

Attachment 46402: Bugfix
https://bugs.webkit.org/attachment.cgi?id=46402&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
>	   def self.parse(string)
>	       haveSeenDiffHeader = false
> -	       linesForDiffs = string.inject([]) do |diffChunks, line|
> +	       diffChunks = linesForDiffs = []
> +	       string.each_line do |line|
>		   if (PrettyPatch.diff_header?(line))
>		       diffChunks << []
>		       haveSeenDiffHeader = true

I think the local variable diffChunks isn't necessary anymore?


More information about the webkit-reviews mailing list