[webkit-reviews] review requested: [Bug 33549] Disallow some sqlite functions that are not safe : [Attachment 46420] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 19:18:52 PST 2010


Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 33549: Disallow some sqlite functions that are not safe
https://bugs.webkit.org/show_bug.cgi?id=33549

Attachment 46420: patch
https://bugs.webkit.org/attachment.cgi?id=46420&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Same patch, with 3 new functions whitelisted:

sqlite_rename_table: used by the ALTER TABLE command
sqlite_rename_trigger: used by the ALTER TRIGGER command
glob: used by the GLOB operator

I've grep'd the sqlite source code for calls to sqlite3CreateFunc() and these
were the only 3 "helper functions" that seem to be registered by the sqlite
code.


More information about the webkit-reviews mailing list