[webkit-reviews] review requested: [Bug 33558] [Android] JavaString uses JSC-specific types : [Attachment 46412] Patch 1 for Bug 33558

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has asked  for review:
Bug 33558: [Android] JavaString uses JSC-specific types
https://bugs.webkit.org/show_bug.cgi?id=33558

Attachment 46412: Patch 1 for Bug 33558
https://bugs.webkit.org/attachment.cgi?id=46412&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
This moves the JSC-specific implementation of JavaString to a private
implementation class. A later change will add the V8 equivalent. Also modifies
JavaField::name and JavaMethod::name to return const JavaString&, rather than
UString::Rep*, which is JSC-specific.

Note that JavaString retains one JSC-specific method, operator UString. This is
required for JSC only to allow UString::rep to be used to represent the
JavaString. To avoid this anomaly, we could move the entire JavaString class to
JSC and V8-specific files, but this means losing the sharing of code between
the two.