[webkit-reviews] review granted: [Bug 33486] Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope : [Attachment 46397] Fix deprecated symbols to allow webkitgtk+ 1.1.18 to compile against gtk+-2.19.3.

[bugzilla-daemon at webkit.org]

David Ronis <David.Ronis at McGill.CA> has granted  review:
Bug 33486: Upgrade 1.1.17->1.1.18 fails:  GTK_WIDGET_TOPLEVEL' was not declared
in this scope
https://bugs.webkit.org/show_bug.cgi?id=33486

Attachment 46397: Fix deprecated symbols to allow webkitgtk+ 1.1.18 to compile
against gtk+-2.19.3.
https://bugs.webkit.org/attachment.cgi?id=46397&action=review

------- Additional Comments from David Ronis <David.Ronis at McGill.CA>
It turns out there were only a few places that the deprecated symbols triggered
a compile error.  The patch fixes there.  Note that one of the changes required
me to cast as:

-    return GTK_WIDGET_CAN_FOCUS(m_webView);
+  return gtk_widget_get_can_focus((GtkWidget*)m_webView);

It compiles but I'm not sure it's right.