[webkit-reviews] review denied: [Bug 31076] [Qt] Odd line wrapping in QtWebKit : [Attachment 46372] suggested patch (with no tabs in the ChangeLogs this time)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 13:04:32 PST 2010


Simon Hausmann <hausmann at webkit.org> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 31076: [Qt] Odd line wrapping in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=31076

Attachment 46372: suggested patch (with no tabs in the ChangeLogs this time)
https://bugs.webkit.org/attachment.cgi?id=46372&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm a bit sceptical about this fix. Please make me less sceptical by turning
your manual test into a layout test :)

The updated layout test only changes its metrics, but the actual line break
doesn't change. So it doesn't really test this bug AFAICS.


More information about the webkit-reviews mailing list