[webkit-reviews] review granted: [Bug 33546] Add V8 bindings for PopStateEvent : [Attachment 46390] v1 patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 12 12:45:52 PST 2010
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Darin Fisher
(:fishd, Google) <fishd at chromium.org>'s request for review:
Bug 33546: Add V8 bindings for PopStateEvent
https://bugs.webkit.org/show_bug.cgi?id=33546
Attachment 46390: v1 patch
https://bugs.webkit.org/attachment.cgi?id=46390&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Yay, except:
> +
> + // NOTE: v8String converts a null String into an empty v8::String :(
> + return v8String(state->toString());
v8StringOrNull
More information about the webkit-reviews
mailing list