[webkit-reviews] review denied: [Bug 33451] error: 'asm' operand requires impossible reload" on OpenBSD/macppc/g++ 4.2.4 : [Attachment 46387] use portable version of TCMalloc_SpinLock on OpenBSD/macppc as it triggers g++ bugs.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 11:59:50 PST 2010


Darin Adler <darin at apple.com> has denied Landry Breuil
<landry at fr.homeunix.org>'s request for review:
Bug 33451: error: 'asm' operand requires impossible reload" on
OpenBSD/macppc/g++ 4.2.4
https://bugs.webkit.org/show_bug.cgi?id=33451

Attachment 46387: use portable version of TCMalloc_SpinLock on OpenBSD/macppc
as it triggers g++ bugs.
https://bugs.webkit.org/attachment.cgi?id=46387&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
You can hand write change log, but it has to be added to the file ChangeLog in
the right format. You can just copy an existing change log entry.

I think making this specific to OPENBSD is bizarre. It should be specific to
the versions of GCC with the bug. But if you don’t have time to do it right, it
might be OK to land it just like this.

But we do need someone to write the change log entry as for all other patches.


More information about the webkit-reviews mailing list