[webkit-reviews] review granted: [Bug 33015] [GTK] Failing media/video-seek-past-end-playing.html : [Attachment 46364] listen on timeupdate event instead of waiting a fixed amount of time, which is prone to test flackyness

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 08:45:19 PST 2010


Eric Carlson <eric.carlson at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 33015: [GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

Attachment 46364: listen on timeupdate event instead of waiting a fixed amount
of time, which is prone to test flackyness
https://bugs.webkit.org/attachment.cgi?id=46364&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
In both tests set timeupdateEventCount to 0 before ending the test. This isn't
necessary and should be removed. A comment about why the test ends after two
timpupdate events would be nice.

r=me with these minor changes.

Extra points if you cleanup video-seek-past-end-playing.html to make it a
reasonable html file instead of the ugly fragment it is now :-)


More information about the webkit-reviews mailing list