[webkit-reviews] review granted: [Bug 33523] [V8] Support injection of inspector scripts into the inspected context : [Attachment 46349] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 33523: [V8]  Support injection of inspector scripts into the inspected
context
https://bugs.webkit.org/show_bug.cgi?id=33523

Attachment 46349: patch
https://bugs.webkit.org/attachment.cgi?id=46349&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    // Create a weak reference to the v8 wrapper of InspectorBackend to
deref
> +    // InspectorBackend when the wrapper is garbage collected.

InspectorBackend?

> +    // Call custom code to create inspector backend wrapper in the utility
context

inspector backend wrapper ?

> +    ASSERT(!v.IsEmpty());
> +    ASSERT(v->IsFunction());
> +

So this script source should evaluate into function? Could you on comment why
it is so?

Otherwise looks good.