[webkit-reviews] review granted: [Bug 33492] [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient : [Attachment 46315] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 11 23:47:54 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 33492: [Chromium] Move getSessionStorageNamespace from WebKitClient to
WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492
Attachment 46315: Patch
https://bugs.webkit.org/attachment.cgi?id=46315&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebViewClient.h
...
> + // Get the session storage namespace associated with this WebView.
> + virtual WebStorageNamespace* createSessionStorageNamespace() { return 0;
}
Fix the comment to say "Create a..."
Also, please move this up into the factory section of WebViewClient.
R=me, but please fix these before committing.
More information about the webkit-reviews
mailing list