[webkit-reviews] review denied: [Bug 33492] [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient : [Attachment 46308] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 33492: [Chromium] Move getSessionStorageNamespace from WebKitClient to
WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

Attachment 46308: Patch
https://bugs.webkit.org/attachment.cgi?id=46308&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   No new tests. (OOPS!)

^^^ need to delete this line

> Index: WebKit/chromium/public/WebKitClient.h
...
> +    // THIS IS DEPRICATED.  WebViewClient::getSessionStorageNamespace() is
the new way to access this.

^^^ deprecated


> Index: WebKit/chromium/public/WebViewClient.h

> +    // Session Storage
------------------------------------------------------
> +
> +    // Get the session storage namespace associated with this WebView.
> +    virtual WebStorageNamespace* getSessionStorageNamespace() { return 0; }

why isn't this called createSessionStorageNamespace?  if the embedder owns the
returned
pointer, then you should just call this sessionStorageNamespace.