[webkit-reviews] review denied: [Bug 33451] error: 'asm' operand requires impossible reload" on OpenBSD/macppc/g++ 4.2.4 : [Attachment 46239] Use portable version of TCMalloc_SpinLock with g++ on ppc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 11 13:51:14 PST 2010


Darin Adler <darin at apple.com> has denied Landry Breuil
<landry at fr.homeunix.org>'s request for review:
Bug 33451: error: 'asm' operand requires impossible reload" on
OpenBSD/macppc/g++ 4.2.4
https://bugs.webkit.org/show_bug.cgi?id=33451

Attachment 46239: Use portable version of TCMalloc_SpinLock with g++ on ppc
https://bugs.webkit.org/attachment.cgi?id=46239&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for contributing a patch!

Three problems:

    1) Needs a ChangeLog.
    2) I believe the code in question works find on Mac OS X on PowerPC, and
this patch changes things so it won't use it any more on that platform.
    3) Not clear this is the right solution to the problem. Is this a
workaround for a compiler bug or a real issue.

review- because of problems (1) and (2) at least.


More information about the webkit-reviews mailing list