[webkit-reviews] review requested: [Bug 33484] [GTK] Add and cleanup return values of signals in view and frame : [Attachment 46297] Add and cleanup return values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 11 12:16:28 PST 2010


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 33484: [GTK] Add and cleanup return values of signals in view and frame
https://bugs.webkit.org/show_bug.cgi?id=33484

Attachment 46297: Add and cleanup return values
https://bugs.webkit.org/attachment.cgi?id=46297&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
I noticed that the return values are missing from some of the signal in
WebKitWebView and one in WebKitWebFrame. This causes confusion when looking up
a signal and either having crashing code or lacking documented variables.

While I was at it, I changed existing @return tags into Return value: for
better readability.


More information about the webkit-reviews mailing list