[webkit-reviews] review requested: [Bug 32819] [GTK] Change the tooltip implementation : [Attachment 46288] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 11 10:41:45 PST 2010
Alejandro G. Castro <alex at igalia.com> has asked for review:
Bug 32819: [GTK] Change the tooltip implementation
https://bugs.webkit.org/show_bug.cgi?id=32819
Attachment 46288: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=46288&action=review
------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
I did both modifications, with this approach we do not ask gtk to send queries
if webkit did not set a string in the tooltip. I guess it is a better option to
avoid launching the query signal when we know there is no string to be
rendered. I've also reviewed the gtk+ version check.
More information about the webkit-reviews
mailing list