[webkit-reviews] review granted: [Bug 33468] PluginView::m_mode not initialized when constructed with null PluginPackage : [Attachment 46281] Same thing yet again, but not adding a new bug..

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 33468: PluginView::m_mode not initialized when constructed with null
PluginPackage
https://bugs.webkit.org/show_bug.cgi?id=33468

Attachment 46281: Same thing yet again, but not adding a new bug..
https://bugs.webkit.org/attachment.cgi?id=46281&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Another way to fix this is to get rid of m_mode and replace it with a function.


The value of m_mode never changes and so is always based on m_loadManually and
is used in only 3 places in the tree.

I'm especially mystified by the code in Qt's PluginView::setNPWindowIfNeeded
that checks for m_mode values other than NP_EMBED and NP_FULL. Seems clearly to
be dead code.