[webkit-reviews] review granted: [Bug 30883] [Gtk] Implement AtkText for HTML elements which contain text : [Attachment 46218] caret offset and event adjustments - take 2

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted  review:
Bug 30883: [Gtk] Implement AtkText for HTML elements which contain text
https://bugs.webkit.org/show_bug.cgi?id=30883

Attachment 46218: caret offset and event adjustments - take 2
https://bugs.webkit.org/attachment.cgi?id=46218&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Thank you, your explanations were really helpful :)

About the error code, just checking at the function it seems it can fail in a
number of ways (the internal state of the range is wrong, the node you pass is
wrong, the document of the range and the node you pass are not the same, ...),
so you could just check none of those happen and otherwise maybe set the offset
to some error value (-1?). But you can do that in a follow-up as far as I'm
concerned, so r+