[webkit-reviews] review requested: [Bug 33349] http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot : [Attachment 46263] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 11 00:35:05 PST 2010
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 33349: http/tests/security/xss-DENIED-window-open-javascript-url.html timed
out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349
Attachment 46263: Patch
https://bugs.webkit.org/attachment.cgi?id=46263&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
Here is my attempt.
We can remove the use of layoutTestController.waitUntilDone() and instead test
whether the parent of the newly opened window is equal to the current window.
If so, then the test passed.
Notice, since this is a JavaScript URL, the parent of the newly opened window
will be about:blank, if successful. And about:blank is different from the
current window. Hence, we say the test fails when the parent of the newly
opened window is not equal to the current window.
More information about the webkit-reviews
mailing list