[webkit-reviews] review granted: [Bug 30437] REGRESSION: Japanese text search ignores small vs. large and voicing mark differences : [Attachment 46249] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 30437: REGRESSION: Japanese text search ignores small vs. large and voicing
mark differences
https://bugs.webkit.org/show_bug.cgi?id=30437

Attachment 46249: patch
https://bugs.webkit.org/attachment.cgi?id=46249&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +static void normalizeCharacters(const UChar* characters, unsigned length,
Vector<UChar>& buffer)
> +{
> +    ASSERT(length);
> +
> +    UErrorCode status = U_ZERO_ERROR;
> +    size_t bufferSize = unorm_normalize(characters, length, UNORM_NFC, 0, 0,
0, &status);
> +    ASSERT(status == U_BUFFER_OVERFLOW_ERROR);
> +    ASSERT(bufferSize);

Would it make sense to try with an output buffer of size length,, to avoid
having two passes in most cases?

> Index: LayoutTests/fast/text/find-kana.html

I need to add a similar test for Russian!

r=me