[webkit-reviews] review requested: [Bug 33453] [Qt] MediaPlayerPrivate: expose supported types to WebCore : [Attachment 46246] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 10 15:29:58 PST 2010
Jakub Wieczorek <faw217 at gmail.com> has asked for review:
Bug 33453: [Qt] MediaPlayerPrivate: expose supported types to WebCore
https://bugs.webkit.org/show_bug.cgi?id=33453
Attachment 46246: patch
https://bugs.webkit.org/attachment.cgi?id=46246&action=review
------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
This patch uses Phonon::BackendCapabilities to get the supported media types.
Note: to work-around the fact that GStreamer does not list MIME types such as
video/ogg, audio/ogg, video/mp4 even if it supports them, the code will check
for other types equivalent to them. The Gtk port does the same thing. Perhaps
this kind of work-around should go into Phonon itself.
More information about the webkit-reviews
mailing list