[webkit-reviews] review requested: [Bug 33419] [XSSAuditor] Add XSSAuditor support to Qt DRT : [Attachment 46234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 10 09:25:09 PST 2010


Robert Hogan <robert at roberthogan.net> has asked  for review:
Bug 33419: [XSSAuditor] Add XSSAuditor support to Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33419

Attachment 46234: Patch
https://bugs.webkit.org/attachment.cgi?id=46234&action=review

------- Additional Comments from Robert Hogan <robert at roberthogan.net>
Support for XSSAuditor needs to set both the global and page settings so that
pages opened from the test inherit the setting. This is required for at least
one test (open-in-new-window.html). It also means that the XSSAuditor should
not be set in the WebPage constructor.

I'm not sure if the failures experienced on the buildbot were related.


More information about the webkit-reviews mailing list