[webkit-reviews] review denied: [Bug 31169] Need to implement WebGLContextAttributes : [Attachment 46195] Revised patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Kenneth Russell <kbr at google.com>'s
request for review:
Bug 31169: Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169

Attachment 46195: Revised patch
https://bugs.webkit.org/attachment.cgi?id=46195&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think a problem here is that you're making GraphicsContext3D depend on the
DOM type WebGLContextAttributes -- it should not be.  The dependence on DOM
types in GraphicsContext3D is a serious design bug that we need to fix, adding
yyet more dependencies is a bad thing.

I would suggest that these arguments simply be passed as either bool or enum
parameters to GraphicsContext3D constructor.  I'd also like to get shared
storage and implementation of these attributes, rather than having platform
ifdefs scattered throughout the code.  We spent a lot of time rectifying this
in the 2d context, doing it in the 3d context seems bad.